This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lot of improvements to the library code coverage, bringing it from around 75% to 99%.
A lot of refactors have made to the annotating reading engine to make this possible, including extracting the
ReflectionClass
reading engine into a newReader
class. TheReader
class handles pulling annotations off classes, methods, and within methods, for passing into the generalParser
engine.This allows us to easily mock the
Reader
provider/class, so instead of requiring us to have a grip of fixture files for the purpose of code coverage, we can now just pass a docblock of annotations into the reader.And while this branch doesn't bring the library up to 100%, we're close enough to there that I can move on and onto fixing other bugs.
Fixes #28.