This repository has been archived by the owner on May 23, 2024. It is now read-only.
Slimming down the error annotation and removing type/subtype support. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing type/subtype system on
@api-errorfor swapping in error strings doesn't always work out that great in real world usage, and in the Vimeo API we end up eschewing it completely for a fully custom error message.This feature is super niche and it's not worth making this a configurable message because we'll still run into the cases of most instances not fitting properly within it.
So because of all that, we're removing this feature from
@api-errorannotations.