-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby 2.7 and update some gems #1508
Add ruby 2.7 and update some gems #1508
Conversation
This is great @dounokouno! I think personally, my vote would be to make more of a 'hard switch.' Now that docker rules the world, I don't see much point in officially supporting more than one version of Ruby. So if you'd like, you are welcome to drop Ruby 2.5 and 2.6 support in this PR. Either way, we'll need a change to the docs which is README.md and any other file that references a Ruby version in the ./docs folder. |
Do not we need to consider the case where we want to run errbit application (mainly puma) and MongoDB on separate servers or instances instead of using Of course, the contents of I'm currently using For the time being, I just wanted to tell you that there are such people, and that there is such a way of thinking, so if @stevecrozz and other main maintainers can make the final decision, that's okay 🙆♂️ So, if you comment that you should keep only one version of Ruby 2.7 and MongoDB, I would like to do so 👍 Excuse me for the long sentence. thank you for reading it until the very end. |
These are good thoughts. My impression is that most people do not deploy errbit with this exact docker-compose.yml file. It is here mainly as an example. Now, the versions of Ruby and Mongo to support I think are two separate discussions. My thought here is we don't need to support more than one version of Ruby. Regarding mongo, that is a bit different and I'd like users to have the flexibility to use with a variety of mongo versions and hopefully the AWS lookalike (DocumentDB). We barely use any mongo features and I can't remember the last time we had a mongo version related issue. So how many versions of mongo should we test? My instinct is to say we should test 2 versions, the lowest officially supported version and the highest one. So it looks like that is 4.0 and 5.0. Can you think of any good reason to also test 4.2 and 4.4? It seems like a waste of CPU cycles to me. |
hi, Thank you for your reply. I agree with the idea of supported versions of ruby. I think the need to test multiple versions is low. I don't know much about the supported versions of MongoDB, so I'll do some research. |
No worries. @dounokouno. We can carry on for now without changing our mongodb support matrix. Let's just make the Ruby support change and come back to mongo another time. |
Thank you for your reply. And I'm sorry for the late reply. Currently, I'm a little busy personally, and I haven't been able to continue the PR corrections or verify the operation with docker-compose. Once the current busy situation has subsided, I will continue to revise this PR. I think I'll be back in a while, so please wait for a while. Thank you. |
…e is non-trivial in circleci
@burnettk Thank you for your supports and merging 🎉 |
Hi,
I've made a lot of corrections and it may be difficult to confirm, but please review. (If you would like to separate the PRs for the revisions, please comment to that effect.)
I have modified the following:
daemonize
option has disappeared from puma v5, and is required systemd and etc for always startup. Therefore, I updated to the final version of v4 series.Gemfile.lock
for more details.rubocop-performance
ubocop-rails
bigdecimal
gem to support Ruby v2.7.app/assets/config/manifest.js
, probably because the sprockets update required it.And I have not modified the following:
Next upcoming my tasks:
docker-compose.yml
.I've already confirmed that all tests are passing in circleCI.
Thank you.