Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasl: make_tar/2 extrafiles option #8843

Closed
wants to merge 3 commits into from

Conversation

vances
Copy link
Contributor

@vances vances commented Sep 21, 2024

Corrects issue #8842 by simply changing the order of the tuple elements in type spec for the ExtraFiles option of sasl:make_tar/2.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

CT Test Results

  2 files   18 suites   8m 59s ⏱️
204 tests 201 ✅ 3 💤 0 ❌
233 runs  230 ✅ 3 💤 0 ❌

Results for commit 1d69540.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@vances vances changed the title Sasl make tar extrafiles sasl: make_tar/2 extrafiles option Sep 21, 2024
@IngelaAndin IngelaAndin added the team:VM Assigned to OTP team VM label Sep 23, 2024
@jhogberg jhogberg self-assigned this Oct 3, 2024
@jhogberg
Copy link
Contributor

jhogberg commented Oct 3, 2024

Thanks for the PR! There's a few unrelated commits there, can you remove them so I can add this to our nightly builds?

@jhogberg jhogberg added the testing currently being tested, tag is used by OTP internal CI label Oct 3, 2024
@vances vances closed this Oct 3, 2024
@vances vances deleted the sasl-make_tar-extrafiles branch October 3, 2024 09:25
@jhogberg jhogberg removed the testing currently being tested, tag is used by OTP internal CI label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants