-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTP-19158][OTP-19221] whaileee/maint-25/inets/httpc_improvements #8788
base: maint-25
Are you sure you want to change the base?
[OTP-19158][OTP-19221] whaileee/maint-25/inets/httpc_improvements #8788
Conversation
This pr closes #8538 |
ipv6_host_with_brackets = BracketedHost, | ||
request_options = Options}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipv6_host_with_brackets = BracketedHost, | |
request_options = Options}, | |
ipv6_host_with_brackets = BracketedHost, | |
request_options = Options}, |
#request{method = Method, | ||
path = Path, | ||
pquery = Query, | ||
headers = Headers, | ||
content = Content, | ||
address = Address, | ||
abs_uri = AbsUri, | ||
headers_as_is = HeadersAsIs, | ||
settings = HttpOptions, | ||
userinfo = UserInfo, | ||
request_options = Options}) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#request{method = Method, | |
path = Path, | |
pquery = Query, | |
headers = Headers, | |
content = Content, | |
address = Address, | |
abs_uri = AbsUri, | |
headers_as_is = HeadersAsIs, | |
settings = HttpOptions, | |
userinfo = UserInfo, | |
request_options = Options}) -> | |
#request{method = Method, | |
path = Path, | |
pquery = Query, | |
headers = Headers, | |
content = Content, | |
address = Address, | |
abs_uri = AbsUri, | |
headers_as_is = HeadersAsIs, | |
settings = HttpOptions, | |
userinfo = UserInfo, | |
request_options = Options}) -> |
?hcrt("send", | ||
[{send_addr, SendAddr}, | ||
{socket, Socket}, | ||
{method, Method}, | ||
{path, Path}, | ||
{pquery, Query}, | ||
{headers, Headers}, | ||
{content, Content}, | ||
{address, Address}, | ||
{abs_uri, AbsUri}, | ||
{headers_as_is, HeadersAsIs}, | ||
{settings, HttpOptions}, | ||
{userinfo, UserInfo}, | ||
{request_options, Options}]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?hcrt("send", | |
[{send_addr, SendAddr}, | |
{socket, Socket}, | |
{method, Method}, | |
{path, Path}, | |
{pquery, Query}, | |
{headers, Headers}, | |
{content, Content}, | |
{address, Address}, | |
{abs_uri, AbsUri}, | |
{headers_as_is, HeadersAsIs}, | |
{settings, HttpOptions}, | |
{userinfo, UserInfo}, | |
{request_options, Options}]), | |
?hcrt("send", | |
[{send_addr, SendAddr}, | |
{socket, Socket}, | |
{method, Method}, | |
{path, Path}, | |
{pquery, Query}, | |
{headers, Headers}, | |
{content, Content}, | |
{address, Address}, | |
{abs_uri, AbsUri}, | |
{headers_as_is, HeadersAsIs}, | |
{settings, HttpOptions}, | |
{userinfo, UserInfo}, | |
{request_options, Options}]), |
send(Receiver, Msg) when is_pid(Receiver) | ||
orelse is_reference(Receiver) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
send(Receiver, Msg) when is_pid(Receiver) | |
orelse is_reference(Receiver) -> | |
send(Receiver, Msg) when is_pid(Receiver); is_reference(Receiver) -> |
{http, {RequestId, {ok, saved_to_file}}} -> | ||
unalias(ClientAlias), | ||
{ok, saved_to_file}; | ||
{http, {RequestId, {error, Reason}}} -> | ||
unalias(ClientAlias), | ||
{error, Reason}; | ||
{http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | ||
unalias(ClientAlias), | ||
Body = maybe_format_body(BinBody, Options), | ||
{ok, {StatusLine, Headers, Body}}; | ||
{http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | ||
unalias(ClientAlias), | ||
Body = maybe_format_body(BinBody, Options), | ||
{ok, {StatusCode, Body}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{http, {RequestId, {ok, saved_to_file}}} -> | |
unalias(ClientAlias), | |
{ok, saved_to_file}; | |
{http, {RequestId, {error, Reason}}} -> | |
unalias(ClientAlias), | |
{error, Reason}; | |
{http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | |
unalias(ClientAlias), | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusLine, Headers, Body}}; | |
{http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | |
unalias(ClientAlias), | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusCode, Body}} | |
{http, {RequestId, {ok, saved_to_file}}} -> | |
true = unalias(ClientAlias), | |
{ok, saved_to_file}; | |
{http, {RequestId, {error, Reason}}} -> | |
true = unalias(ClientAlias), | |
{error, Reason}; | |
{http, {RequestId, {ok, {StatusLine, Headers, BinBody}}}} -> | |
true = unalias(ClientAlias), | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusLine, Headers, Body}}; | |
{http, {RequestId, {ok, {StatusCode, BinBody}}}} -> | |
true = unalias(ClientAlias), | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusCode, Body}} |
unalias(ClientAlias), | ||
receive | ||
{http, {RequestId, {ok, saved_to_file}}} -> | ||
{ok, saved_to_file}; | ||
{http, {RequestId, {error, Reason}}} -> | ||
{error, Reason}; | ||
{http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | ||
Body = maybe_format_body(BinBody, Options), | ||
{ok, {StatusLine, Headers, Body}}; | ||
{http, {RequestId, {ok, {StatusCode,BinBody}}}} -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unalias(ClientAlias), | |
receive | |
{http, {RequestId, {ok, saved_to_file}}} -> | |
{ok, saved_to_file}; | |
{http, {RequestId, {error, Reason}}} -> | |
{error, Reason}; | |
{http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusLine, Headers, Body}}; | |
{http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | |
true = unalias(ClientAlias), | |
receive | |
{http, {RequestId, {ok, saved_to_file}}} -> | |
{ok, saved_to_file}; | |
{http, {RequestId, {error, Reason}}} -> | |
{error, Reason}; | |
{http, {RequestId, {ok, {StatusLine, Headers, BinBody}}}} -> | |
Body = maybe_format_body(BinBody, Options), | |
{ok, {StatusLine, Headers, Body}}; | |
{http, {RequestId, {ok, {StatusCode, BinBody}}}} -> |
case Sync of | ||
true -> | ||
{Ref, {ok, {StatusLine, Headers, BinBody}}}; | ||
_ -> | ||
{Ref, {StatusLine, Headers, BinBody}} | ||
end; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case Sync of | |
true -> | |
{Ref, {ok, {StatusLine, Headers, BinBody}}}; | |
_ -> | |
{Ref, {StatusLine, Headers, BinBody}} | |
end; | |
case Sync of | |
true -> | |
{Ref, {ok, {StatusLine, Headers, BinBody}}}; | |
_ -> | |
{Ref, {StatusLine, Headers, BinBody}} | |
end; |
{_, Status, _} = StatusLine, | ||
case Sync of | ||
true -> | ||
{Ref, {ok, {Status, BinBody}}}; | ||
_ -> | ||
{Ref, Status, BinBody} | ||
end; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{_, Status, _} = StatusLine, | |
case Sync of | |
true -> | |
{Ref, {ok, {Status, BinBody}}}; | |
_ -> | |
{Ref, Status, BinBody} | |
end; | |
{_, Status, _} = StatusLine, | |
case Sync of | |
true -> | |
{Ref, {ok, {Status, BinBody}}}; | |
_ -> | |
{Ref, Status, BinBody} | |
end; |
CT Test Results 2 files 21 suites 12m 20s ⏱️ For more details on these failures, see this check. Results for commit d1b27b2. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
No description provided.