[OTP-19158][OTP-19221] whaileee/maint-25/inets/httpc_improvements #8788
+151
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr closes #8538 |
vkatsuba
reviewed
Sep 6, 2024
Comment on lines
+805
to
+806
| ipv6_host_with_brackets = BracketedHost, | ||
| request_options = Options}, |
There was a problem hiding this comment.
Suggested change
| ipv6_host_with_brackets = BracketedHost, | |
| request_options = Options}, | |
| ipv6_host_with_brackets = BracketedHost, | |
| request_options = Options}, |
Comment on lines
+58
to
+68
| #request{method = Method, | ||
| path = Path, | ||
| pquery = Query, | ||
| headers = Headers, | ||
| content = Content, | ||
| address = Address, | ||
| abs_uri = AbsUri, | ||
| headers_as_is = HeadersAsIs, | ||
| settings = HttpOptions, | ||
| userinfo = UserInfo, | ||
| request_options = Options}) -> |
There was a problem hiding this comment.
Suggested change
| #request{method = Method, | |
| path = Path, | |
| pquery = Query, | |
| headers = Headers, | |
| content = Content, | |
| address = Address, | |
| abs_uri = AbsUri, | |
| headers_as_is = HeadersAsIs, | |
| settings = HttpOptions, | |
| userinfo = UserInfo, | |
| request_options = Options}) -> | |
| #request{method = Method, | |
| path = Path, | |
| pquery = Query, | |
| headers = Headers, | |
| content = Content, | |
| address = Address, | |
| abs_uri = AbsUri, | |
| headers_as_is = HeadersAsIs, | |
| settings = HttpOptions, | |
| userinfo = UserInfo, | |
| request_options = Options}) -> |
Comment on lines
+70
to
+83
| ?hcrt("send", | ||
| [{send_addr, SendAddr}, | ||
| {socket, Socket}, | ||
| {method, Method}, | ||
| {path, Path}, | ||
| {pquery, Query}, | ||
| {headers, Headers}, | ||
| {content, Content}, | ||
| {address, Address}, | ||
| {abs_uri, AbsUri}, | ||
| {headers_as_is, HeadersAsIs}, | ||
| {settings, HttpOptions}, | ||
| {userinfo, UserInfo}, | ||
| {request_options, Options}]), |
There was a problem hiding this comment.
Suggested change
| ?hcrt("send", | |
| [{send_addr, SendAddr}, | |
| {socket, Socket}, | |
| {method, Method}, | |
| {path, Path}, | |
| {pquery, Query}, | |
| {headers, Headers}, | |
| {content, Content}, | |
| {address, Address}, | |
| {abs_uri, AbsUri}, | |
| {headers_as_is, HeadersAsIs}, | |
| {settings, HttpOptions}, | |
| {userinfo, UserInfo}, | |
| {request_options, Options}]), | |
| ?hcrt("send", | |
| [{send_addr, SendAddr}, | |
| {socket, Socket}, | |
| {method, Method}, | |
| {path, Path}, | |
| {pquery, Query}, | |
| {headers, Headers}, | |
| {content, Content}, | |
| {address, Address}, | |
| {abs_uri, AbsUri}, | |
| {headers_as_is, HeadersAsIs}, | |
| {settings, HttpOptions}, | |
| {userinfo, UserInfo}, | |
| {request_options, Options}]), |
vkatsuba
reviewed
Sep 6, 2024
Comment on lines
+153
to
+154
| send(Receiver, Msg) when is_pid(Receiver) | ||
| orelse is_reference(Receiver) -> |
There was a problem hiding this comment.
Suggested change
| send(Receiver, Msg) when is_pid(Receiver) | |
| orelse is_reference(Receiver) -> | |
| send(Receiver, Msg) when is_pid(Receiver); is_reference(Receiver) -> |
vkatsuba
reviewed
Sep 6, 2024
Comment on lines
+870
to
+883
| {http, {RequestId, {ok, saved_to_file}}} -> | ||
| unalias(ClientAlias), | ||
| {ok, saved_to_file}; | ||
| {http, {RequestId, {error, Reason}}} -> | ||
| unalias(ClientAlias), | ||
| {error, Reason}; | ||
| {http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | ||
| unalias(ClientAlias), | ||
| Body = maybe_format_body(BinBody, Options), | ||
| {ok, {StatusLine, Headers, Body}}; | ||
| {http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | ||
| unalias(ClientAlias), | ||
| Body = maybe_format_body(BinBody, Options), | ||
| {ok, {StatusCode, Body}} |
There was a problem hiding this comment.
Suggested change
| {http, {RequestId, {ok, saved_to_file}}} -> | |
| unalias(ClientAlias), | |
| {ok, saved_to_file}; | |
| {http, {RequestId, {error, Reason}}} -> | |
| unalias(ClientAlias), | |
| {error, Reason}; | |
| {http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | |
| unalias(ClientAlias), | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusLine, Headers, Body}}; | |
| {http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | |
| unalias(ClientAlias), | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusCode, Body}} | |
| {http, {RequestId, {ok, saved_to_file}}} -> | |
| true = unalias(ClientAlias), | |
| {ok, saved_to_file}; | |
| {http, {RequestId, {error, Reason}}} -> | |
| true = unalias(ClientAlias), | |
| {error, Reason}; | |
| {http, {RequestId, {ok, {StatusLine, Headers, BinBody}}}} -> | |
| true = unalias(ClientAlias), | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusLine, Headers, Body}}; | |
| {http, {RequestId, {ok, {StatusCode, BinBody}}}} -> | |
| true = unalias(ClientAlias), | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusCode, Body}} |
vkatsuba
reviewed
Sep 6, 2024
Comment on lines
+886
to
+895
| unalias(ClientAlias), | ||
| receive | ||
| {http, {RequestId, {ok, saved_to_file}}} -> | ||
| {ok, saved_to_file}; | ||
| {http, {RequestId, {error, Reason}}} -> | ||
| {error, Reason}; | ||
| {http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | ||
| Body = maybe_format_body(BinBody, Options), | ||
| {ok, {StatusLine, Headers, Body}}; | ||
| {http, {RequestId, {ok, {StatusCode,BinBody}}}} -> |
There was a problem hiding this comment.
Suggested change
| unalias(ClientAlias), | |
| receive | |
| {http, {RequestId, {ok, saved_to_file}}} -> | |
| {ok, saved_to_file}; | |
| {http, {RequestId, {error, Reason}}} -> | |
| {error, Reason}; | |
| {http, {RequestId, {ok, {StatusLine,Headers,BinBody}}}} -> | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusLine, Headers, Body}}; | |
| {http, {RequestId, {ok, {StatusCode,BinBody}}}} -> | |
| true = unalias(ClientAlias), | |
| receive | |
| {http, {RequestId, {ok, saved_to_file}}} -> | |
| {ok, saved_to_file}; | |
| {http, {RequestId, {error, Reason}}} -> | |
| {error, Reason}; | |
| {http, {RequestId, {ok, {StatusLine, Headers, BinBody}}}} -> | |
| Body = maybe_format_body(BinBody, Options), | |
| {ok, {StatusLine, Headers, Body}}; | |
| {http, {RequestId, {ok, {StatusCode, BinBody}}}} -> |
vkatsuba
reviewed
Sep 6, 2024
Comment on lines
+1759
to
+1764
| case Sync of | ||
| true -> | ||
| {Ref, {ok, {StatusLine, Headers, BinBody}}}; | ||
| _ -> | ||
| {Ref, {StatusLine, Headers, BinBody}} | ||
| end; |
There was a problem hiding this comment.
Suggested change
| case Sync of | |
| true -> | |
| {Ref, {ok, {StatusLine, Headers, BinBody}}}; | |
| _ -> | |
| {Ref, {StatusLine, Headers, BinBody}} | |
| end; | |
| case Sync of | |
| true -> | |
| {Ref, {ok, {StatusLine, Headers, BinBody}}}; | |
| _ -> | |
| {Ref, {StatusLine, Headers, BinBody}} | |
| end; |
Comment on lines
+1766
to
+1772
| {_, Status, _} = StatusLine, | ||
| case Sync of | ||
| true -> | ||
| {Ref, {ok, {Status, BinBody}}}; | ||
| _ -> | ||
| {Ref, Status, BinBody} | ||
| end; |
There was a problem hiding this comment.
Suggested change
| {_, Status, _} = StatusLine, | |
| case Sync of | |
| true -> | |
| {Ref, {ok, {Status, BinBody}}}; | |
| _ -> | |
| {Ref, Status, BinBody} | |
| end; | |
| {_, Status, _} = StatusLine, | |
| case Sync of | |
| true -> | |
| {Ref, {ok, {Status, BinBody}}}; | |
| _ -> | |
| {Ref, Status, BinBody} | |
| end; |
CT Test Results 2 files 21 suites 12m 20s ⏱️ For more details on these failures, see this check. Results for commit d1b27b2. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.