Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: ssh_notes.md supervision tree diagram update #8773

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

u3s
Copy link
Contributor

@u3s u3s commented Sep 2, 2024

No description provided.

@u3s u3s added team:PS Assigned to OTP team PS enhancement labels Sep 2, 2024
@u3s u3s self-assigned this Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

CT Test Results

    2 files     29 suites   18m 18s ⏱️
  460 tests   456 ✅  4 💤 0 ❌
1 665 runs  1 641 ✅ 24 💤 0 ❌

Results for commit b9486ed.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s changed the base branch from master to maint September 3, 2024 11:41
@u3s u3s added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Sep 3, 2024
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Sep 3, 2024
end
```
## Questions
1. ssh_subsystem_sup - one_for_all and auto_shutdown ... any process crash results with ssh_subsystem_sup shutdown?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short answer: No 😉

Long answer: see EEP-56:

Otherwise, the following rules apply when a significant child exits on its own:

  • A transient child will be restarted (not cause a supervisor shutdown) if it exits abnormally. If it exits normally…
    * if the supervisor auto_shutdown flag is any_significant, the supervisor will shut down
    * if the supervisor auto_shutdown flag is all_significant, the supervisor will shut down if the child was the last active significant child

  • A temporary child will never be restarted. If it exits normally or abnormally, the same rules as for transient children apply, in regard to the supervisor auto_shutdown flag.

[...]

To be clear, the above rules only apply when significant children exit by themselves, that is, not when being terminated manually via supervisor:terminate_child/2, not when other non-significant children exit, and not when being terminated as a consequence of a sibling’s death in the one_for_all or rest_for_one strategies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. this is just a scratchpad ...
thanks for commenting anyway :-)

@u3s u3s merged commit ef05703 into erlang:maint Sep 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants