Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dap] limit the watch list to variables in the current frame #905

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

TheGeorge
Copy link
Contributor

It's not possible to have fully-fledged expressions through the interpreter in the watch list:

  • each evaluate through the meta process triggers an update to the stack frame
  • an update to the frame triggers an update to the watch list (which triggers an update to the frame)

This limits this to extracting variables from the current frame, similar to hover. There are some potential things we can do, e.g. erl_eval in the project node, but it's an easy way to break the DAP.

I'll revisit this when working on the REPL.

@TheGeorge TheGeorge changed the title limit the watch list to variables in the current frame [dap] limit the watch list to variables in the current frame Feb 10, 2021
@robertoaloi robertoaloi merged commit 934fd67 into erlang-ls:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants