Do not read file from disk on didOpen #1298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs the language server should not try to access the file from disk:
Erlang LS erroneously does that. This can cause a server crash if the file is not available in the location specified by the Uri.
Using
app
as default source since the only side effect is to index references and signatures for the document, which is not a big problem if it is done also for a dependency or a file which is part of OTP.Fixes #1296