Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DAP Error Handling #1246

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Improve DAP Error Handling #1246

merged 4 commits into from
Mar 17, 2022

Conversation

robertoaloi
Copy link
Member

Description

This PR collects a number of fixes around DAP error handling.

  • Exit code should be a number, not a string
  • Do not silently crash DAP if distribution is not available
  • Fix ErrorResponse format
  • Show errors to users
  • Increase severity of log messages for distribution shutdown errors
  • Add missing clause to handle ignored answer from net_kernel

TheGeorge
TheGeorge approved these changes Mar 17, 2022
View reviewed changes
apps/els_dap/src/els_dap_general_provider.erl
, <<"timeout">> := TimeOut
, <<"use_long_names">> := UseLongNames}} ->
case Params of
#{ <<"runinterminal">> := Cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a good place for future refactoring

@robertoaloi robertoaloi merged commit 3ef713c into main Mar 17, 2022
@robertoaloi robertoaloi deleted the fixes-to-dap-distribution branch March 17, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheGeorge TheGeorge TheGeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertoaloi @TheGeorge