Avoid negative line numbers in elvis diagnostics. #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Yes, a fix to Elvis would be lovely. |
|
The fix for elvis is already merged too, and in fact they even put out a new version on hex.pm! Nice guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that elvis will set line number to 0 for the atom_naming_convention diagnostic, which results in ErlangLS sending -1 as line number to the LSP client. This makes at least VS code not show any other elvis diagnostics, even other diagnostics with valid line numbers.
This fix will set line number to 1 if we get 0 or below from elvis.
Will try to make a pull request to elvis_core as well to make it send an actual line number, but I think this precaution can still be good.