Safer incremental sync #1222
Merged
Safer incremental sync #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* didOpen: Handle indexing through els_index_buffer to avoid race * didSave: Read and index file through els_index_buffer, this should introduce a synchronization point if the index data has become out of sync.
robertoaloi
approved these changes
Feb 24, 2022
| @@ -42,6 +43,15 @@ apply_edits_async(Uri, Edits) -> | |||
| ?SERVER ! {apply_edits, Uri, Edits}, | |||
| ok. | |||
|
|
|||
| -spec load(uri(), binary()) -> ok. | |||
There was a problem hiding this comment.
As a follow up, we should probably convert this to a gen server.
| TextDocument = maps:get(<<"textDocument">>, Params), | ||
| Uri = maps:get(<<"uri">> , TextDocument), | ||
| #{<<"textDocument">> := #{<<"uri">> := Uri}} = Params, | ||
| {ok, Text} = file:read_file(els_uri:path(Uri)), |
There was a problem hiding this comment.
I wonder how this play with different editors. Both in Emacs and VS Code, if the current version of the "buffer" is different from disk, you get a warning. Maybe it doesn't matter?
There was a problem hiding this comment.
I think this should be fine as if we get didSave my assumption is that it must mean that the file has been written to disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synchronization point if the index data has become out of sync.
Fixes some of the issues raised in #1220.
We still need to implement support for
didChangeWatchedFiles