Revert "Precompute list of enabled diagnostics" #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f6decd. This change introduced a regression in the debugger, preventing it from starting. The `els_dap` escript invokes the `els_config` initialization procedure (see 4b475b0), but the new version of the initialization depends on the `els_diagnostics` module, which is part of the `els_lsp` application, not included in the `els_dap` escript. For now simply reverting the change, but we should revisit the application structure. The original idea was for an application to contain the implementation of the JSON-RPC protocol and for the `els_dap` and `els_lsp` to utilize that as a dependency. That never really happened and the current application split in Erlang LS in its current form feels a bit arbitrary. One may argue that Erlang LS could get rid of the umbrella structure and be a single application.
michalmuskala
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2f6decd.
This change introduced a regression in the debugger, preventing it from starting.
The
els_dapescript invokes theels_configinitialization procedure(see 4b475b0),
but the new version of the initialization depends on the
els_diagnosticsmodule,which is part of the
els_lspapplication, not included in theels_dapescript.For now simply reverting the change, but we should revisit the application structure.
The original idea was for an application to contain the implementation of the JSON-RPC protocol
and for the
els_dapandels_lspto utilize that as a dependency. That never really happenedand the current application split in Erlang LS in its current form feels a bit arbitrary.
One may argue that Erlang LS could get rid of the umbrella structure and be a single application.