Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve goto definition for variables #1187

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

plux
Copy link
Contributor

@plux plux commented Jan 31, 2022

Description

Improve goto definition for variables

  • Use same scoping rules as variable renaming
  • No longer limited to only variables inside functions
  • Add support for finding variable references

@plux
Copy link
Contributor Author

plux commented Jan 31, 2022

Note: Test is failing due to dependency on #1186 which isn't merged yet.

@robertoaloi
Copy link
Member

@plux #1186 is now merged. Feel free to rebase.

* Use same scoping rules as variable renaming
* No longer limited to only variables inside functions
* Add support for finding variable references
@plux plux force-pushed the improve-goto-definition-variable branch from 369e086 to 12040af Compare February 1, 2022 20:45
@plux
Copy link
Contributor Author

plux commented Feb 1, 2022

rebased 👍

Copy link
Member

@robertoaloi robertoaloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff, thanks!

@robertoaloi robertoaloi merged commit 5ee868c into erlang-ls:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants