Fix parsing trailing comments in modules #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlfmt_parser returns a `raw_string` form for comments which are after the last form in the file and not followed by any more form. It was not expected by els_parser that a raw_string can contain no tokens (just comments and whitespace). A file with no code just whitespace has the same result. Fixes erlang-ls#1171
gomoripeti
commented
Jan 19, 2022
Comment on lines
+114
to
+117
| %% `els_parser:parse' actually catches the exception and only prints a warning | ||
| %% log. In order to make sure there is no crash, we need to call an internal | ||
| %% debug function that would really crash and make the test case fail | ||
| error = els_parser:parse_incomplete_text(Text1, {1, 1}), |
There was a problem hiding this comment.
I wonder if there is a better way to make sure no warning log is emitted in ct tests?
There was a problem hiding this comment.
Not sure I'm following 100%, but an option could be to (eventually isolate and) mock with passthrough the function generating the warning and check from CT if the function was called via meck_history or similar.
robertoaloi
approved these changes
Jan 20, 2022
|
I will merge this now, given it causes crashes. Feel free to provide the CT change as a follow up. Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlfmt_parser returns a
raw_stringform for comments which are after the lastform in the file and not followed by any more form. It was not expected by
els_parser that a raw_string can contain no tokens (just comments and
whitespace). A file with no code just whitespace has the same result.
Fixes #1171