Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/flow actions #14

Merged
merged 10 commits into from
Jul 24, 2023
Merged

Feature/flow actions #14

merged 10 commits into from
Jul 24, 2023

Conversation

erikdrobne
Copy link
Owner

@erikdrobne erikdrobne commented Jul 23, 2023 •
edited
Loading

  • Introduce the CoordinatorAction type and actions handler method func handle(_ action: CoordinatorAction) instead of direct route navigation
  • Improve documentation
  • Add a method func remove(coordinator: Coordinator) which takes a Coordinator as a parameter and removes it from the list of child's list.
  • Update unit tests.
  • Coordinator is not conforming to the NSObject anymore.

@erikdrobne erikdrobne requested a review from tadelv July 23, 2023 21:15
tadelv
tadelv approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@tadelv tadelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like that Coordinator moved away from NSObject. Also Actions seem like a good idea.

@erikdrobne erikdrobne merged commit 8cfc205 into main Jul 24, 2023
1 check passed
@erikdrobne erikdrobne deleted the feature/flow-actions branch July 24, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelv tadelv tadelv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikdrobne @tadelv