Feature/custom transitions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelv
reviewed
May 15, 2023
tadelv
approved these changes
May 16, 2023
tadelv
reviewed
May 19, 2023
| view.navigationTitle(value) | ||
| } | ||
|
|
||
| .navigationTitle(route.title ?? "") |
There was a problem hiding this comment.
I ran some tests and with this change, if the NavigationRoute.title property is nil, an empty string will be set as the title of the corresponding ViewController. This means that when pushing another controller on the stack, the back button will have an empty string instead of the system Back text.
Not sure if this is intentional or not?
There was a problem hiding this comment.
You're right, needs to be resolved before merging.
tadelv
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support (API) for custom transitions.