Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VR600 Support #4

Merged
merged 6 commits into from
May 6, 2020
Merged

Add VR600 Support #4

merged 6 commits into from
May 6, 2020

Conversation

GuyKh
Copy link
Contributor

@GuyKh GuyKh commented May 5, 2020

Solves #2

@GuyKh
Copy link
Contributor Author

GuyKh commented May 5, 2020

Don't merge yet.

As a script this works but I want to test it in HA

@ericpignet
Copy link
Owner

Thanks for the contribution!
I let you test in HA, let me know when it's ready!

@GuyKh
Copy link
Contributor Author

GuyKh commented May 6, 2020

@ericpignet

2020-05-06 10:36:01 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Retrieving PublicKey...
2020-05-06 10:36:01 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Failed to get AuthTokens. Retrying in 3 secs.
2020-05-06 10:36:04 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Retrieving PublicKey...
2020-05-06 10:36:04 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Retrieving JSessionID...
2020-05-06 10:36:05 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Retrieving Token...
2020-05-06 10:36:05 INFO (SyncWorker_19) [custom_components.tplink_router.device_tracker] Loading wireless clients...`

Looks great!

@ericpignet
Copy link
Owner

Well done, thanks for the contribution!
Is pull request ready to merge?
(looks good but I'll give it a try anyway, just to check Tplink6DeviceScannerit doesn't fail abruptly, preventing other scanners to be tried)

@GuyKh
Copy link
Contributor Author

GuyKh commented May 6, 2020

@ericpignet on my end - yes.
Here and there I see that 192.168.1.1 times out - but that's not in the initialization step.
So I'm kinda comfortable with merging this

@ericpignet
Copy link
Owner

There were a few formatting issues: inconsistent indentation (2 chars), trailing whitespaces, double new lines. But that's alright, I'm planning to do an update shortly to clean up the logging, I'll take the opportunity to reformat.
I'm merging your PR.
Thanks again!

@ericpignet ericpignet merged commit 2df9730 into ericpignet:master May 6, 2020
@GuyKh GuyKh deleted the patch-1 branch May 6, 2020 20:34
@GuyKh
Copy link
Contributor Author

GuyKh commented May 7, 2020

@ericpignet - thanks for your notes.
For some reason I didn't see this when comitting, but I'll put extra attention to it.

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants