Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/covid 19 green digital certificates test #5

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2021

In DigitalGreenCertificateServiceIntegrationTest is copied code from MockIdpClientTest to resolve the test pkis. Let me know if I should add a comment in the source-code about the origin (git commit log contains the information already) or generalize the approach.

@richard-infai richard-infai self-assigned this Jun 7, 2021
@ghost
Copy link
Author

ghost commented Jun 7, 2021

/cc @richard-infai

@ghost
Copy link
Author

ghost commented Jun 7, 2021

/cc @ManuelB

Copy link
Contributor

@ManuelB ManuelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht super aus.

@ManuelB ManuelB merged commit 1871ab5 into feature/covid-19-green-digital-certificates Jun 7, 2021
@ghost ghost deleted the feature/covid-19-green-digital-certificates-test branch June 7, 2021 12:11
@ManuelB ManuelB restored the feature/covid-19-green-digital-certificates-test branch June 12, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants