Ere 307 #20
Closed
Ere 307 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for better encapsulation and overall slightly cleaner code.
still need to tackle the 2-3 medicines. Some cleaning in Websocket.java in anticipation of ERE-300/301. Some general cleaning about encapsulation and avoiding using null when possible.
support per bundle. The QR code start being too big after 7 though. Some refactoring to make the tests cleaner.
|
EDIT: The tests generating the pdfs have been disabled with an explanation. |
|
@barelyThinkingBagOfWater Feel free to: comment out the test with a comment that the test is too slow. |
the overall build without testing any business logic
|
I just merged this into main as requested by Matthias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using the latest template for the prescriptions.
Bundles/Prescriptions are now filtered by patient as requested in comments of Jira task.
After 9 (maybe 8, please confirm) medicines per prescription the QR code top-right becomes too big, I've added a limit to avoid this problem.