Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude servlet-api dependencies from avalon-framework #17

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2021

The referenced library version of servlet-api in avalon-framework
is rather old such that it interferes with some tests in the
feature/covide19-digital-green-certificates branch.

The referenced library version of servlet-api in avalon-framework
is rather old such that it interferes with some tests in the
feature/covide19-digital-green-certificates branch.
@ghost
Copy link
Author

ghost commented Jun 10, 2021

I am entirely uncertain of the implications of this exclusion. Maybe there is a negative influence on the package that uses the avalon-framework (I think, its the barcode4j dependency). Please make sure to not break existing functionality with this dependency exclusion!

@ghost ghost requested review from cartel1 and ManuelB June 10, 2021 08:32
@ghost
Copy link
Author

ghost commented Jun 10, 2021

Note: based on an investigation with @richard-infai

@ManuelB
Copy link
Contributor

ManuelB commented Jun 10, 2021

@tempuser5432 the avalon framework is mainly used for Apache FOP which is generating PDFs. we don't need it here.

@ghost
Copy link
Author

ghost commented Jun 10, 2021

So this may be integrated in the feature/covid19-green-digital-certificate branch without any worries? I would still prefere to not deviate from the main branch for shared files such that - at some point - the feature branch may be integrated into the main branch.

However, if you feel uncomfortable adding this change to the main branch, I will just add it to the feature branch.

@ManuelB
Copy link
Contributor

ManuelB commented Jun 10, 2021

@tempuser5432 feel free to add this pull request

@ManuelB ManuelB closed this Jun 12, 2021
@ManuelB ManuelB deleted the feature/exclude-old-dependency branch June 12, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant