Ere 148 #11
Merged
Ere 148 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static code analysis on pull_request.
is closer to and under @test and hopefully it's enough
pipeline. I added it with some fake path in it. If we used the lowercase variables in application.properties instead of referencing directly the env variables we wouldn't need the .env file.
|
Nice. I checked the results. Caching the maven repository would speed up the build a lot. |
|
Just saw that caching bis already done. |
xbarrelet
pushed a commit
that referenced
this pull request
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 CI pipeline configuration files. On push a mvn verify is done, on pull request some static code analysis are additionally undertaken for information (can be ignored and blocks nothing).
You can see the result here : https://github.com/ere-health/ere-ps-app/actions