Additional default OOXML namespace aliases #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http:https://schemas.microsoft.com/office/word/2010/wordprocessingGroup namespace is expected to have an alias of "wpg" by LO 6.4. Having a different alias caused LibreOffice to not display grouped drawings. I copied some additional default namespace aliases from sample files, to hopefully prevent such errors in the future.
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 92.72% 92.78% +0.05%
==========================================
Files 24 24
Lines 1843 1843
Branches 110 109 -1
==========================================
+ Hits 1709 1710 +1
Misses 24 24
+ Partials 110 109 -1
Continue to review full report at Codecov.
|
|
Thank you for this amazing work! |
|
Released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http:https://schemas.microsoft.com/office/word/2010/wordprocessingGroupnamespace is expected to have an alias ofwpgby LO 6.4. Having a different alias caused LibreOffice to not display grouped drawings.I added some additional default namespace aliases from sample files also, to hopefully prevent some later errors caused by this.
A previous issue and PR with the same main cause: #55, #56