Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm tools.logging #86

Merged
merged 22 commits into from
Sep 22, 2021
Merged

feat: rm tools.logging #86

merged 22 commits into from
Sep 22, 2021

Conversation

erdos
Copy link
Owner

@erdos erdos commented Aug 15, 2021

remove tools.logging dependency and add a minimal slf4j integration.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #86 (ea0aa6f) into master (ad026e0) will increase coverage by 0.00%.
The diff coverage is 65.21%.

❗ Current head ea0aa6f differs from pull request most recent head 5a3344b. Consider uploading reports for the commit 5a3344b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          24       25    +1     
  Lines        1843     1857   +14     
  Branches      109      110    +1     
=======================================
+ Hits         1710     1723   +13     
  Misses         24       24           
- Partials      109      110    +1     
Impacted Files Coverage Δ
src/stencil/process.clj 76.74% <0.00%> (+2.32%) ⬆️
src/stencil/log.clj 50.00% <50.00%> (ø)
src/stencil/eval.clj 100.00% <100.00%> (+10.71%) ⬆️
src/stencil/infix.clj 98.32% <100.00%> (+1.11%) ⬆️
src/stencil/postprocess/images.clj 100.00% <100.00%> (ø)
src/stencil/postprocess/list_ref.clj 92.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad026e0...5a3344b. Read the comment docs.

@erdos erdos added the docker label Aug 20, 2021
@erdostw erdostw marked this pull request as ready for review September 3, 2021 19:11
@erdostw erdostw merged commit 72bcca1 into master Sep 22, 2021
@erdostw erdostw deleted the feat-rm-toolslogging branch September 22, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants