Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #74

Merged
merged 6 commits into from
Jul 5, 2021
Merged

chore: cleanup #74

merged 6 commits into from
Jul 5, 2021

Conversation

erdos
Copy link
Owner

@erdos erdos commented Jul 4, 2021

  • remove unused code
  • make docker app build reproducible
  • chore: remove io! macro calls from inner functions

@erdos erdos added the good first issue Good for newcomers label Jul 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #74 (58bde71) into master (ce02138) will increase coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   92.00%   92.09%   +0.09%     
==========================================
  Files          24       23       -1     
  Lines        1775     1771       -4     
  Branches      110      110              
==========================================
- Hits         1633     1631       -2     
+ Misses         32       30       -2     
  Partials      110      110              
Impacted Files Coverage Δ
src/stencil/tree_postprocess.clj 100.00% <ø> (ø)
src/stencil/types.clj 100.00% <ø> (+4.34%) ⬆️
src/stencil/util.clj 98.46% <ø> (+1.44%) ⬆️
src/stencil/process.clj 78.57% <25.00%> (+0.52%) ⬆️
src/stencil/model.clj 95.51% <85.71%> (-0.57%) ⬇️
src/stencil/model/common.clj 92.30% <100.00%> (+5.64%) ⬆️
src/stencil/postprocess/list_ref.clj 92.45% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce02138...58bde71. Read the comment docs.

@erdostw erdostw merged commit 4b11abd into master Jul 5, 2021
@erdostw erdostw deleted the cleanup-1 branch July 5, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants