Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate exception on EvaluatedDocument.toInputStream #37

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

erdos
Copy link
Owner

@erdos erdos commented Jul 15, 2020

Fixes #34 by wrapping the produced InputStream in a proxy that throws the wrapped exception on the .close() method call.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          19       19           
  Lines        1429     1429           
  Branches       83       83           
=======================================
  Hits         1316     1316           
  Misses         30       30           
  Partials       83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b133256...d58fada. Read the comment docs.

@erdos erdos merged commit 3fef019 into master Sep 16, 2020
@erdos erdos deleted the fix-toinputstream-err branch September 16, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EvaluatedDocument.toInputStream usage may result in corrupt documents
2 participants