Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyperlinks #30

Merged
merged 5 commits into from
Sep 13, 2019
Merged

fix: hyperlinks #30

merged 5 commits into from
Sep 13, 2019

Conversation

erdos
Copy link
Owner

@erdos erdos commented Sep 13, 2019

Fixes #29.

The problem was that the resource-copier function was looking for hyperlink targets as files in the extract directory.

The fix adds extra logic for hyperlinks.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #30 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   91.58%   91.62%   +0.04%     
==========================================
  Files          19       19              
  Lines        1390     1397       +7     
  Branches       84       84              
==========================================
+ Hits         1273     1280       +7     
  Misses         33       33              
  Partials       84       84
Impacted Files Coverage Δ
src/stencil/model.clj 92.51% <100%> (+0.18%) ⬆️
src/stencil/ooxml.clj 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34e196...5c05dd2. Read the comment docs.

@erdos erdos merged commit 09dc039 into master Sep 13, 2019
@erdos erdos deleted the fix-hyperlinks branch September 13, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not parse template file with hyperlinks
3 participants