Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fragment names #27

Merged
merged 6 commits into from
Jun 5, 2019
Merged

Feature/fragment names #27

merged 6 commits into from
Jun 5, 2019

Conversation

erdos
Copy link
Owner

@erdos erdos commented Jun 4, 2019

add a getAllFragmentNames method to the TemplateVariables class to query all referenced fragment names. Solves #26

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #27 into master will decrease coverage by 0.15%.
The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage    91.3%   91.14%   -0.16%     
==========================================
  Files          19       19              
  Lines        1368     1389      +21     
  Branches       84       88       +4     
==========================================
+ Hits         1249     1266      +17     
  Misses         35       35              
- Partials       84       88       +4
Impacted Files Coverage Δ
src/stencil/model.clj 92.33% <100%> (ø) ⬆️
src/stencil/process.clj 76.92% <81.25%> (+1.92%) ⬆️
src/stencil/cleanup.clj 92.95% <83.33%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8e39d...94971d6. Read the comment docs.

@erdos
Copy link
Owner Author

erdos commented Jun 4, 2019

Seems good to me.

The coverage decrease is due to a bug in cloverage in handling the for macro.

Some manual testing is required, but will be included in the next release in a few days.

@erdos erdos merged commit 5df8ea8 into master Jun 5, 2019
@erdos erdos deleted the feature/fragment-names branch June 5, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants