performance improvements by removing unnecessary parallelism #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdos
changed the title
erdos
added a commit
that referenced
this pull request
Apr 25, 2019
Removed call to future macro in process.clj eliminates the need to use clojure's agent pool.
erdos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change removes the usage of parallelism by eliminating
futurecalls inprocess.clj.This lets us remove multithreading from the compiled
native-imageversion of the standalone application reducing executable file size by about 4% and runtime by almost 50%.Removes the need to call
(shutdown-agents)after using the library to shut down Clojure's agent thread pools.