Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dynamic links - replaceLink function #150

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mbali
Copy link
Contributor

@mbali mbali commented Oct 11, 2023

This feature enables the creation of dynamic links in the template document.

The hyperlink URLs are stored in the .rels files, so the most direct approach was to create a new replaceLink function using the replaceImage implementation as "inspiration".

This feature enables the creation of dynamic links in the template document.
The hyperlink URLs are stored in the `.rels` files, so the most direct approach was to create a new `replaceLink` function using the `replaceImage` implementation as "inspiration".
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #150 (b050537) into master (4ee128b) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.21%   93.46%   +0.24%     
==========================================
  Files          28       29       +1     
  Lines        2004     2034      +30     
  Branches      107      104       -3     
==========================================
+ Hits         1868     1901      +33     
  Misses         29       29              
+ Partials      107      104       -3     
Files Coverage Δ
src/stencil/ooxml.clj 100.00% <100.00%> (ø)
src/stencil/postprocess/links.clj 100.00% <100.00%> (ø)
src/stencil/tree_postprocess.clj 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erdos erdos merged commit 7f84d1e into erdos:master Oct 11, 2023
2 of 4 checks passed
@erdos
Copy link
Owner

erdos commented Oct 11, 2023

Big thanks for your awesome contribution @mbali! The code and docs are on point. Your changes are live in version 0.5.4 now.

@mbali mbali deleted the feature/replace-links branch October 12, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants