Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numbering from fragments #148

Merged
merged 38 commits into from
Jul 13, 2023
Merged

fix: numbering from fragments #148

merged 38 commits into from
Jul 13, 2023

Conversation

erdos
Copy link
Owner

@erdos erdos commented Apr 23, 2023

Numberings in fragments do not copy the numberings definition xml and the parent definitions are used (when found).

@erdos erdos added the cross-references cross-references and numberings label Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #148 (7b0b23e) into master (3876a31) will decrease coverage by 0.03%.
The diff coverage is 93.81%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   93.23%   93.21%   -0.03%     
==========================================
  Files          28       28              
  Lines        1922     2003      +81     
  Branches      105      107       +2     
==========================================
+ Hits         1792     1867      +75     
- Misses         25       29       +4     
- Partials      105      107       +2     
Impacted Files Coverage Δ
src/stencil/model/numbering.clj 93.54% <92.00%> (-0.90%) ⬇️
src/stencil/model.clj 97.14% <100.00%> (+0.24%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erdos erdos force-pushed the fix-numbering-fragment-23q2 branch from 1c58498 to aa36e7a Compare April 25, 2023 09:23
@erdos erdos force-pushed the fix-numbering-fragment-23q2 branch from aa36e7a to ebcf428 Compare April 25, 2023 09:24
@erdos erdos marked this pull request as ready for review July 13, 2023 08:19
@erdos erdos merged commit 996ba6a into master Jul 13, 2023
3 of 5 checks passed
@erdos erdos deleted the fix-numbering-fragment-23q2 branch July 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-references cross-references and numberings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant