Set workflow failfast #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 63 63
Lines 3012 3012
=======================================
Hits 2762 2762
Misses 250 250Continue to review full report at Codecov.
|
milesgranger
approved these changes
Dec 10, 2019
This ensures that the workflow attempts to build all models even if some fail.
86714d5
to
912c695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures it tries to build all models even if some fail. Today it has kind of accidantially worked since our model-building things are themselves a step-template. Ref argoproj/argo-workflows#1442