Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kent!
I managed to convert this workshop from JavaScript to TypeScript.
I tested this myself and it's working as intended. 😊
I'm aware that in different workshops, the TypeScript version exists within the "next" branch, but because it doesn't exist, I wanted to let you know in some way that I wanted to apply my changes.
My additional notes:
@ts-nocheck
because I couldn't manage to resolve the typings issues. I think that this isn't as important to be typed as other parts of the workshop (but I can be wrong).const cell = state.grid[row][column]
- this throws error in TypeScript since it could beundefined
.I managed to fix this by creating an array and trying to access it.
const cell = Array.from(state.grid[row] ?? [])[column] ?? 0
But for me, it looks like an excessive workaround and I presume that there's a better solution than this.