Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout nesting tip to the SEO chapters #93

Merged
merged 2 commits into from
May 31, 2024

Conversation

julianobrasil
Copy link
Contributor

@julianobrasil julianobrasil commented May 31, 2024

It can be confusing to people that once they set the meta override to the app/routes/users+/$username.tsx file, the pages in the child URLs seem to ignore the overridden information.

This PR adds some notes on the solution page of the "Meta Overrides" activity to refresh the concept of "layout-nesting" vs "url-nesting", already shown in the "Routes" part.

It can be confusing to people that once they set the `meta` override to the `app/routes/users+/$username.tsx` file, the pages in the child URL seem to ignore those overrides.

This PR adds some notes on the solution page of the "Meta Overrides" activity to refresh that information, already shown in the "Routes" part.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks!

exercises/06.seo/02.solution.nested/README.mdx Outdated Show resolved Hide resolved
@kentcdodds kentcdodds merged commit 8b5e526 into epicweb-dev:main May 31, 2024
1 check passed
@julianobrasil julianobrasil deleted the patch-1 branch May 31, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants