Fix false positive test #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On exercises/01.styling/01.solution.public-links, the test is expected to test against a nullable value where it could be an undefined.
kentcdodds
reviewed
May 6, 2024
| @@ -3,6 +3,6 @@ import { test, expect } from '@playwright/test' | |||
| test('checks favicon', async ({ page }) => { | |||
| await page.goto('/') | |||
| const favicon = await page.$('link[rel="icon"]') | |||
| const href = await favicon?.getAttribute('href') | |||
| const href = await favicon?.getAttribute('href') ?? null | |||
There was a problem hiding this comment.
Rather than a conditional in our test, let's use a better assertion that covers the undefined case
There was a problem hiding this comment.
I updated it to use a toBeTruthy assertion. In this case it covers 3 possibilities: an empty string, null and undefined.
IMO, it is vaguely express the test, "A link href to be truthy?". But it is considerably better than adding more condition in the test unnecessary. Thank you for pointing that out.
madrus
pushed a commit
to madrus/epicweb-full-stack-foundations
that referenced
this pull request
May 14, 2024
madrus
added a commit
to madrus/epicweb-full-stack-foundations
that referenced
this pull request
May 14, 2024
* upstream/main: Fix false positive test (epicweb-dev#91) Revert "add tip to custom scripts exercise step" add tip to custom scripts exercise step chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app
madrus
added a commit
to madrus/epicweb-full-stack-foundations
that referenced
this pull request
May 14, 2024
* main: Fix false positive test (epicweb-dev#91) Revert "add tip to custom scripts exercise step" add tip to custom scripts exercise step chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app Fix false positive test (epicweb-dev#91) Revert "add tip to custom scripts exercise step" add tip to custom scripts exercise step chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app chore: update @epic-web/workshop-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On exercises/01.styling/01.solution.public-links, the test is expected to test against a nullable value where it could be an undefined. To fix this, either make the testing value a nullable or use a more suitable value assertion https://playwright.dev/docs/api/class-genericassertions#methods