Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint, Prettier, Prisma, and Tailwind #67

Merged
merged 1 commit into from
May 19, 2023
Merged

Add ESLint, Prettier, Prisma, and Tailwind #67

merged 1 commit into from
May 19, 2023

Conversation

andrecasal
Copy link
Contributor

Add recommended extensions for VS Code

@onemen
Copy link
Contributor

onemen commented May 19, 2023

I think that we also need a way to share ESlint and Prettier configuration to prevent VScode from automatically change the code when our local VScode configuration does not match @kentcdodds configuration

@andrecasal
Copy link
Contributor Author

At the moment, Prettier's config lives in package.json. Wouldn't it be more obvious where prettier's config lives if we had a .prettierrc file instead (that's how I overrode some of the rules in package.json btw)?

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds
Copy link
Member

I'm fine if someone wants to move the prettier config out of the package.json, but this isn't required for getting this merged.

@kentcdodds kentcdodds merged commit 6f8fa41 into epicweb-dev:main May 19, 2023
@andrecasal andrecasal deleted the recommended-extensions branch May 22, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants