Fix simulateError()
on Memo component
#2525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing
TypeError: Cannot read property 'displayNameOfNode' of undefined
errors and I believe I tracked it down to a regression introduced in #2482. ThedisplayNameOfNode()
method now referencesthis
but withsimulateError()
it ends up being called unbound. My fix is to just always bindadapter.displayNameOfNode
sothis
is alwaysadapter
.Thanks!