Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: React 15.0 and 15.1 #2495

Merged
merged 5 commits into from
Mar 30, 2021
Merged

Fixes: React 15.0 and 15.1 #2495

merged 5 commits into from
Mar 30, 2021

Conversation

mul53
Copy link
Contributor

@mul53 mul53 commented Jan 31, 2021

Fixes majority of failing tests

@codecov
Copy link

codecov bot commented Jan 31, 2021 •
edited
Loading

Codecov Report

Merging #2495 (db8e4c6) into master (b542bda) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
+ Coverage   96.29%   96.31%   +0.01%     
==========================================
  Files          49       49              
  Lines        4183     4204      +21     
  Branches     1123     1130       +7     
==========================================
+ Hits         4028     4049      +21     
  Misses        155      155
Impacted Files Coverage Δ
...-adapter-react-15.4/src/ReactFifteenFourAdapter.js 96.53% <100.00%> (+0.45%) ⬆️
...enzyme-adapter-react-15/src/ReactFifteenAdapter.js 96.02% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b542bda...db8e4c6. Read the comment docs.

ljharb
ljharb approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/enzyme-test-suite/test/shared/methods/html.jsx Show resolved Hide resolved
packages/enzyme-test-suite/test/shared/methods/render.jsx Show resolved Hide resolved
packages/enzyme-adapter-utils/src/Utils.js Outdated Show resolved Hide resolved
@mul53 mul53 force-pushed the bugfixes/react-15 branch 2 times, most recently from f1c3509 to e005ce0 Compare February 1, 2021 20:58
@ljharb

This comment has been minimized.

Sign in to view
@ljharb ljharb merged commit db8e4c6 into enzymejs:master Mar 30, 2021
ljharb added a commit that referenced this pull request Mar 30, 2021
@ljharb
[enzyme-adapter-react-15.4] v1.4.4
2da70ba 
 - [fix] handle DOM nodes in react v15.0 and v15.1 (#2495)
 - [fix] fix `nodeType` for `v15.0`-`v15.1` (#2495)
 - [deps] update `react-is`
 - [deps] update `object.values`
 - [dev deps] update `@babel/cli`, `@babel/core`, `eslint`, `eslint-plugin-react`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
package: react adapter: 15 package: react adapter: 15.4 semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mul53 @ljharb