ci: Minor cleanup for build script #27780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
|
cc @alecholmez |
|
pushing this through to fix sync in go-control-plane i suspect this will fix a few other issues also |
This was referenced Jun 3, 2023
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env var
NO_BUILD_SETUPis used to skip running./ci/build_setup.shIt was moved into the file itself to make the file idempotent, but i inadvertently made it
exitrather thanreturn- this fixes thatThis fix is necessary for the go-control-plane repo to sync correctly
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]