Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix cache mount #27778

Merged
merged 1 commit into from
Jun 8, 2023
Merged

ci: Fix cache mount #27778

merged 1 commit into from
Jun 8, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Jun 3, 2023

The Docker publishing job now caches the docker build image, and the docker cache for building images (and the bazel cache)

For other jobs, the Docker cache is loaded to/from tmpfs to speed up caching, for the Docker job there is insufficient room for this, so this switches it to using fs

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title ci: Fix cache mount [WIP] ci: Fix cache mount Jun 3, 2023
@phlax phlax marked this pull request as draft June 3, 2023 13:46
@phlax phlax changed the title [WIP] ci: Fix cache mount ci: Fix cache mount Jun 3, 2023
@phlax phlax marked this pull request as ready for review June 3, 2023 16:17
@phlax phlax changed the title ci: Fix cache mount [WIP] ci: Fix cache mount Jun 3, 2023
@phlax phlax marked this pull request as draft June 3, 2023 16:59
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax changed the title [WIP] ci: Fix cache mount ci: Fix cache mount Jun 3, 2023
@phlax phlax marked this pull request as ready for review June 3, 2023 17:49
phlax added a commit to phlax/envoy that referenced this pull request Jun 3, 2023
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to the code. Seems a simple flag was added to tell the script should use the mount path or not.

But I didn't get the context. Why it's necessary. Would be better to add some descrition in the PR. Thanks.

phlax added a commit that referenced this pull request Jun 5, 2023
Signed-off-by: Ryan Northey <[email protected]>
@ravenblackx ravenblackx self-assigned this Jun 8, 2023
@phlax phlax merged commit df77824 into envoyproxy:main Jun 8, 2023
asheryerm pushed a commit to asheryerm/envoy that referenced this pull request Jul 5, 2023
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asheryer <[email protected]>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants