Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix latest docs publishing #27608

Merged
merged 1 commit into from
May 24, 2023
Merged

ci: Fix latest docs publishing #27608

merged 1 commit into from
May 24, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented May 24, 2023

In #27514 one of the env vars that the docs/build.sh script uses to determine whether to create rst or html was lost

this resolves it

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft May 24, 2023 09:27
@phlax phlax changed the title [WIP] ci: Fix latest docs publishing ci: Fix latest docs publishing May 24, 2023
@phlax phlax marked this pull request as ready for review May 24, 2023 09:59
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax enabled auto-merge (squash) May 24, 2023 10:24
@wbpcode
Copy link
Member

wbpcode commented May 24, 2023

it would be better to add a short description about what's broken and why this fix it.

@phlax phlax merged commit 2bfacbd into envoyproxy:main May 24, 2023
phlax added a commit to phlax/envoy that referenced this pull request Jun 2, 2023
phlax added a commit that referenced this pull request Jun 5, 2023
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants