Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHV: Enable oghttp2 and UHV in HTTP/2 flood test #27543

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

yanavlasov
Copy link
Contributor

Additional Description:
HTTP/2 flood test was using decommissioned envoy.reloadable_features.http2_new_codec_wrapper flag (which is no-op) and was not using oghttp2 or UHV. This change enables testing of oghttp2 with and without UHV by the flood test.

Also removed duplicated increment of the upstream_cx_protocol_error flag in UHV mode which triggered errors in the flood test.

Risk Level: Low, build flag protected
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@yanavlasov yanavlasov changed the title Enable oghttp2 and UHV in HTTP/2 flood test UHV: Enable oghttp2 and UHV in HTTP/2 flood test May 22, 2023
Copy link
Contributor

@KBaichoo KBaichoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good generally besides the one minor question

source/common/http/codec_client.cc Show resolved Hide resolved
@KBaichoo
Copy link
Contributor

/wait

@KBaichoo KBaichoo merged commit a34e994 into envoyproxy:main Jun 7, 2023
75 checks passed
asheryerm pushed a commit to asheryerm/envoy that referenced this pull request Jul 5, 2023
Enable oghttp2 and UHV in HTTP/2 flood test

Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: asheryer <[email protected]>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Enable oghttp2 and UHV in HTTP/2 flood test

Signed-off-by: Yan Avlasov <[email protected]>
Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants