chore(dlb): remove unused isOpen call #27539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
force-pushed
the
chcbi
branch
2 times, most recently
from
e9b2802
to
b33cdc7
Compare
Signed-off-by: spacewander <[email protected]>
|
cc @daixiang0 Hi, could you take a look at this PR when you have free time? Thanks. |
daixiang0
reviewed
May 23, 2023
| #ifdef DLB_DISABLED | ||
| socket->isOpen(); |
There was a problem hiding this comment.
Yeah, this line is to make CI happy before, now we can remove it.
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Signed-off-by: spacewander <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: remove unused isOpen call
Additional Description: The call
socket->isOpen()is unnecessary as we throw an exception after itRisk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]