Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic proxy: add support to the original dst cluster and subset lb #27502

Merged
merged 1 commit into from
May 31, 2023

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented May 19, 2023

Commit Message: generic proxy: add support to the original dst cluster and subset lb
Additional Description:

Minor extending to the generic router filter make it support the donstreamConnection and metadataMatchCriteria. Then the subset lb and original dst cluster could be used for generic proxy.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

@wbpcode
Copy link
Member Author

wbpcode commented May 19, 2023

/retest

@wbpcode
Copy link
Member Author

wbpcode commented May 23, 2023

friendly ping @soulxu

@phlax
Copy link
Member

phlax commented May 30, 2023

/wait-any for review

cc @soulxu

@soulxu
Copy link
Member

soulxu commented May 30, 2023

sorry for forgetting this one, I will give a try tomorrow morning

Copy link
Member

@soulxu soulxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@wbpcode wbpcode assigned phlax and unassigned ggreenway May 31, 2023
@wbpcode
Copy link
Member Author

wbpcode commented May 31, 2023

Re-assign this to @phlax get a stamp from maintainer. I think you are the on-call maintainer for now? cc @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wbpcode

@phlax phlax merged commit de2ef46 into envoyproxy:main May 31, 2023
75 checks passed
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants