golang filter: register config factory and config parser in a single API #27351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API. Signed-off-by: doujiang24 <[email protected]>
|
/review @wangfakang |
|
/retest |
|
Retrying Azure Pipelines: |
wangfakang
reviewed
May 16, 2023
| // TODO merge it to api.HttpFilterConfigFactory | ||
| func RegisterHttpFilterConfigParser(parser api.StreamFilterConfigParser) { | ||
| httpFilterConfigParser = parser | ||
| func RegisterHttpFilterConfigFactoryAndParser(name string, f api.StreamFilterConfigFactory, parser api.StreamFilterConfigParser) { |
There was a problem hiding this comment.
It would be helpful to add some comments or code-level checks, such as indicating that the "factory" parameter is required and the "parser" parameter is optional.
wangfakang
reviewed
May 16, 2023
Signed-off-by: doujiang24 <[email protected]>
wangfakang
approved these changes
May 17, 2023
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
May 17, 2023
…API (envoyproxy#27351) * golang filter: register config factory and config parser in a single API. Signed-off-by: doujiang24 <[email protected]> * add comment. Signed-off-by: doujiang24 <[email protected]> --------- Signed-off-by: doujiang24 <[email protected]> Signed-off-by: Shriram Rajagopalan <[email protected]>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…API (envoyproxy#27351) * golang filter: register config factory and config parser in a single API. Signed-off-by: doujiang24 <[email protected]> * add comment. Signed-off-by: doujiang24 <[email protected]> --------- Signed-off-by: doujiang24 <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]