Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nghttp: update code comments #22380

Merged
merged 1 commit into from
Jul 26, 2022
Merged

nghttp: update code comments #22380

merged 1 commit into from
Jul 26, 2022

Conversation

daixiang0
Copy link
Member

Signed-off-by: Loong Dai [email protected]

The current code flow is that install logger when ENVOY_NGHTTP2_TRACE is set, while the comment is the opposite.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@zuercher
Copy link
Member

/retest

@zuercher zuercher self-assigned this Jul 26, 2022
@zuercher zuercher enabled auto-merge (squash) July 26, 2022 20:08
@zuercher zuercher merged commit da392ef into envoyproxy:main Jul 26, 2022
@daixiang0 daixiang0 deleted the nglog branch July 27, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants