-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add dlb entrypoint for contrib #22014
Conversation
Signed-off-by: Loong Dai <[email protected]>
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/22014/docs/index.html The docs are (re-)rendered each time the CI |
/retest |
Retrying Azure Pipelines: |
Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daixiang0 apart from the capitalization issues in the titles im wondering how we can differentiate the titles - api <> ref docs
eg searching i see this:
perhaps we need to add something like (config)
at the end of all of the titles in the config section - not sure of best way - would be good to fix
Signed-off-by: Loong Dai <[email protected]>
I am curious about how is the "api-v3" tagged? If we can control it we can add "config" tag as well. |
@daixiang0 could you rebase and i can review again |
@phlax rebased, thanks. |
/retest |
Retrying Azure Pipelines: |
/retest |
Retrying Azure Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @daixiang0
Signed-off-by: Loong Dai [email protected]
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]