Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dlb entrypoint for contrib #22014

Merged
merged 7 commits into from
Jul 27, 2022
Merged

docs: add dlb entrypoint for contrib #22014

merged 7 commits into from
Jul 27, 2022

Conversation

daixiang0
Copy link
Member

Signed-off-by: Loong Dai [email protected]

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22014/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #22014 was opened by daixiang0.

see: more, trace.

@phlax phlax self-assigned this Jul 4, 2022
@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22014 (comment) was created by @daixiang0.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jul 4, 2022

Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
Signed-off-by: Loong Dai <[email protected]>
@daixiang0 daixiang0 requested a review from phlax July 11, 2022 01:57
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daixiang0 apart from the capitalization issues in the titles im wondering how we can differentiate the titles - api <> ref docs

eg searching i see this:

namespacing

perhaps we need to add something like (config) at the end of all of the titles in the config section - not sure of best way - would be good to fix

Signed-off-by: Loong Dai <[email protected]>
@daixiang0
Copy link
Member Author

I am curious about how is the "api-v3" tagged? If we can control it we can add "config" tag as well.

@phlax
Copy link
Member

phlax commented Jul 18, 2022

@daixiang0 could you rebase and i can review again

@daixiang0
Copy link
Member Author

@phlax rebased, thanks.

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #22014 (comment) was created by @daixiang0.

see: more, trace.

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #22014 (comment) was created by @daixiang0.

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @daixiang0

@phlax phlax merged commit 0feb242 into envoyproxy:main Jul 27, 2022
@daixiang0 daixiang0 deleted the entry branch July 28, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants