Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkoutSuccessUrl is never read from the options passed in paymentForm() #257

Closed
wallacio opened this issue Mar 7, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@wallacio
Copy link

wallacio commented Mar 7, 2022

Description

checkoutSuccessUrl is never read from the options passed in paymentForm()

Probably because of this

'checkoutSuccessUrl' => $this->checkoutSuccessUrl,

Which doesn't use the value set here

$checkoutSuccessUrl = $options['checkoutSuccessUrl'] ?? $this->checkoutSuccessUrl;

Steps to reproduce

Render a form using paymentForm(), passing in checkoutSuccessUrl parameter.

{{ paymentForm.paymentForm({
    checkoutSuccessUrl: '/membership/thank-you?order={number}',
    checkoutCancelUrl: entry.url ~ '?status=cancelled'
    }) 
}}

Additional info

  • Craft version: 3.7.34
  • PHP version: 7.4
  • Database driver & version: MariaDB 10.5
  • Plugin version: 3.4.1
  • Is SCA and Stripe Checkout enabled?: Yes
@andrelopez andrelopez self-assigned this Mar 8, 2022
@andrelopez andrelopez added the bug Something isn't working label Mar 8, 2022
@andrelopez
Copy link
Member

Hi @wallacio We just released Stripe Payments v3.4.2 with a fix to this issue. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants