Clean up PrefixList and PrefixMap #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mdickinson
commented
Oct 5, 2021
mdickinson
commented
Oct 5, 2021
traits/trait_types.py
Outdated
| @@ -3141,7 +3156,7 @@ class Map(TraitType): | |||
|
|
|||
| The following example defines a ``Person`` class:: | |||
|
|
|||
| >>> class Person(HasTraits): | |||
| >>> erson(HasTraits): | |||
There was a problem hiding this comment.
Something odd has happened to this line.
There was a problem hiding this comment.
Thanks; should be fixed in e2435a5.
mdickinson
commented
Oct 5, 2021
traits/trait_types.py
Outdated
| @@ -3316,7 +3348,7 @@ def post_setattr(self, object, name, value): | |||
| setattr(object, name + "_", self.mapped_value(value)) | |||
|
|
|||
| def info(self): | |||
| keys = sorted(repr(x) for x in self.map.keys()) | |||
| keys = sorted(repr(x) for x in self.map) | |||
There was a problem hiding this comment.
There's a difference between PrefixList and PrefixMap here: we sort the output for PrefixMap but not PrefixList. Given that we can now rely on ordered dictionaries, I think we should drop the sorted here.
corranwebster
approved these changes
Oct 5, 2021
…ap2' into cleanup/prefix-list-and-prefix-map2
This was referenced Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring and cleanup on the
PrefixListandPrefixMaptrait types. It's a more careful re-invention of the changes in #1563 (extended toPrefixMap).Principal user-facing changes:
ValueErrorrather thanTraitError.default_valueis now explicit in the trait type signature, rather than being extracted from the metadata. (This doesn't change any behaviour, but does improve the documentation and discoverability.)Fixes #955.
Fixes issues described in #1561.