Speed up on_trait_change, part II #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Aug 9, 2021
Comment on lines
+2675
to
2677
| type=lnw.type, | ||
| priority=priority, | ||
| deferred=deferred, |
There was a problem hiding this comment.
Why not make the same changes to these three traits as well? Is that planned in a subsequent PR? type and deferred don't seem to have any static trait change handlers hooked up to them but priority does.
There was a problem hiding this comment.
Subsequent PR. For type and deferred, it's messy, as you'll see when the next PR lands. :-) priority is mostly the same as in this PR, except that it's handled differently at ListenerGroup level.
|
@rahulporuri Thanks for reviewing! Will merge this PR and then merge the main branch into #1492. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR follows on from #1490. It's part of a larger effort to identify and ameliorate performance bottlenecks in the on_trait_change, while not changing the
on_trait_changebehaviour.This PR changes the way that
ListenerItems are initialised. Previously, in theon_trait_changemethod:ListenerParsercreated a tree ofListenerBaseinstances (ListenerItems andListenerGroups),handler,wrapped_handler_refanddispatchtraits were set on the root node of the treeThose static trait-change handlers are one cause of slowness in a large Traits-using system.
With this PR, the
ListenerParsertakes care of provisioning all theListenerItems at creation time, instead of propagating the changes down afterListenerItemcreation.This PR gets us partway to making the
ListenerItemandListenerGroupclasses not need to be traited classes at all. I plan to make at least one more PR to complete that process.This PR should be reviewable commit by commit: all tests should pass at each commit.