Fix trait selection by metadata #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From testing, it looks as though this does fix enthought/envisage#430 completely. |
rahulporuri
approved these changes
Jun 22, 2021
It does. I too have tested this fix locally and I don't see the test failures observed in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1469 made accessing nonexistent double-underscore-named attributes on a cTrait instance an
AttributeError. Unfortunately, Envisage uses a metadata attribute__extension_point__to identify extension points, and the filtering facilities ofHasTraits.traitsandHasTraits.class_traitsfail as a result.This PR fixes calls like
hastraits_obj.traits(__extension_point=True__)andhastraits_obj.class_traits(__extension_point__=True)so that they no longer fail with anAttributeError.Motivated by enthought/envisage#430, but may not fix it completely.